EricGao888 commented on PR #11332: URL: https://github.com/apache/dolphinscheduler/pull/11332#issuecomment-1214702962
> > > I investigated the migration from `jUnit4` to `jUnit5` in other open-source projects, such as `Apache Flink`. `Apache Flink` community once tried to migrate all stuff from 4 to 5 once for all but finally gave up and decided to do it gradually. Currently, as shown in https://github.com/apache/flink/blob/1232629c80cbb64eb4ca9f6c95d6c5c1a2e8e82d/pom.xml#L147-L148 , they have both versions in the project. > > > FYI, here is the mailing thread where they discussed about the migration: https://www.mail-archive.com/[email protected]/msg47657.html > > > WDYT @kezhenxu94 @ruanwenjun @caishunfeng @SbloodyS > > > > > > cc @zhongjiajie > > Maybe there are other historical reasons of flink,dolphischeduler do not have many unitest currently, IMO if we can migrate all of them to junit5 now it is the time @zhongjiajie The workload to migrate all of them is quite large. Currently, because of those `powermock`, I could not give an exact estimate of the specific workload. If we decide to do so, first of all, we need to remove all the code related to powermock #11405 . Then, we need to get back to this PR to add dependency on jUnit5 and manually migrate the complex part which IDE could not do automatically e.g. change `expected = Exception.class` to `Assertions.assertThrows`. After these two done, we could try to use `Intellij` to migrate the rest and see how many of the rest will break. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
