SbloodyS commented on code in PR #11360:
URL: https://github.com/apache/dolphinscheduler/pull/11360#discussion_r945493826


##########
dolphinscheduler-master/src/main/resources/logback-spring.xml:
##########
@@ -74,4 +74,4 @@
         <appender-ref ref="TASKLOGFILE"/>
         <appender-ref ref="MASTERLOGFILE"/>
     </root>
-</configuration>
+</configuration>

Review Comment:
   Same here.



##########
dolphinscheduler-worker/src/main/resources/application.yaml:
##########
@@ -117,4 +118,4 @@ spring:
     driver-class-name: com.mysql.cj.jdbc.Driver
     url: jdbc:mysql://127.0.0.1:3306/dolphinscheduler
     username: root
-    password: root
+    password: root

Review Comment:
   Please remove unnessnary change.



##########
dolphinscheduler-worker/src/main/resources/logback-spring.xml:
##########
@@ -67,11 +67,12 @@
     </appender>
 
     <root level="INFO">
-        <if condition="${DOCKER:-false}">
-            <then>
-                <appender-ref ref="STDOUT"/>
-            </then>
-        </if>
+<!--        <if condition="${DOCKER:-false}">-->
+<!--            <then>-->
+<!--                <appender-ref ref="STDOUT"/>-->
+<!--            </then>-->
+<!--        </if>-->
+        <appender-ref ref="STDOUT"/>

Review Comment:
   Please remove unnessnary change.



##########
dolphinscheduler-api/src/main/resources/logback-spring.xml:
##########
@@ -61,4 +61,4 @@
         <appender-ref ref="STDOUT"/>
         <appender-ref ref="APILOGFILE"/>
     </root>
-</configuration>
+</configuration>

Review Comment:
   Please remove unnessnary change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to