SbloodyS commented on code in PR #11498: URL: https://github.com/apache/dolphinscheduler/pull/11498#discussion_r947410101
########## dolphinscheduler-task-plugin/dolphinscheduler-task-pytorch/src/main/java/org/apache/dolphinscheduler/plugin/task/pytorch/PytorchParameters.java: ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.plugin.task.pytorch; + +import org.apache.dolphinscheduler.plugin.task.api.model.ResourceInfo; +import org.apache.dolphinscheduler.plugin.task.api.parameters.AbstractParameters; + +import org.apache.commons.lang3.StringUtils; + +import java.io.File; +import java.nio.file.Paths; +import java.util.List; + +import lombok.Getter; +import lombok.Setter; +import lombok.ToString; + +@Getter +@Setter +@ToString +public class PytorchParameters extends AbstractParameters { + + private Boolean isCreateEnvironment = false; + private String pythonPath = "."; + private String script; + private String scriptParams; + private String pythonCommand = "${PYTHON_HOME}"; + private String pythonEnvTool = PythonEnvManager.ENV_TOOL_VENV; + private String requirements = "requirements.txt"; + private String condaPythonVersion = "3.9"; + /** + * resource list + */ + private List<ResourceInfo> resourceList; + + @Override + public List<ResourceInfo> getResourceFilesList() { + return resourceList; + } + + @Override + public boolean checkParameters() { + return true; + } + + + public String getRequirementPath() { + return getPossiblePath(requirements); + } + + public String getPythonCommand() { + String command; + if (pythonCommand.isEmpty()) { + command = "${PYTHON_HOME}"; + } else { + command = pythonCommand; + } + return command; + } + + + public String getScriptPath() { + return getPossiblePath(script); + } + + private String getPossiblePath(String filePath) { + String possiblePath = filePath; + File sourceFile = new File(possiblePath); + String newPath = Paths.get(pythonPath, possiblePath).toString(); + File newFile = new File(newPath); + if (newFile.exists() && !sourceFile.exists()) { + possiblePath = newPath; + } else if (resourceList != null) { + String newPathResource = StringUtils.removeStart(newPath, "./"); + for (ResourceInfo resourceInfo : resourceList) { + if (resourceInfo.getResourceName().equals("/" + newPathResource)) { + possiblePath = newPath; + break; + } + } + + Review Comment: > @SbloodyS Just for confirmation, do you mean we need add a formatting rule that there should be only one empty line at the end of java file? Yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
