ruanwenjun commented on code in PR #11504:
URL: https://github.com/apache/dolphinscheduler/pull/11504#discussion_r949756562
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/UsersServiceImpl.java:
##########
@@ -973,17 +969,7 @@ public Map<String, Object> queryAllGeneralUsers(User
loginUser) {
public Map<String, Object> queryUserList(User loginUser) {
Map<String, Object> result = new HashMap<>();
//only admin can operate
- if (!canOperatorPermissions(loginUser,null,
AuthorizationType.ACCESS_TOKEN, USER_MANAGER)) {
- putMsg(result, Status.USER_NO_OPERATION_PERM);
- return result;
- }
-
- QueryWrapper<User> queryWrapper = new QueryWrapper<>();
- queryWrapper.ge("id", 0);
- if (loginUser.getUserType().equals(UserType.GENERAL_USER)) {
- queryWrapper.eq("id", loginUser.getId());
- }
- List<User> userList = userMapper.selectList(null);
+ List<User> userList = userMapper.queryEnabledUsers();
Review Comment:
This is unsafe, all user can query all other user information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
