ruanwenjun commented on code in PR #11542:
URL: https://github.com/apache/dolphinscheduler/pull/11542#discussion_r951209580
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/registry/ServerNodeManager.java:
##########
@@ -227,6 +221,16 @@ public void run() {
}
}
+
+ protected void handleAddr(Map<String, String> newWorkerNodeInfo,
WorkerGroup wg, Set<String> nodes) {
+ String[] addrs = wg.getAddrList().split(Constants.COMMA);
+ for (String addr : addrs) {
+ if (newWorkerNodeInfo.containsKey(addr)) {
+ nodes.add(addr);
+ }
+ }
+ }
Review Comment:
it's better to rename this method to `protected Set<String>
getNodeAddress(Map<String, String> newWorkerNodeInfo, WorkerGroup workgroup)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
