jieguangzhou commented on code in PR #11606:
URL: https://github.com/apache/dolphinscheduler/pull/11606#discussion_r952435798
##########
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/tasks/switch.py:
##########
@@ -107,7 +107,7 @@ def set_define_attr(self) -> None:
num_branch_default += 1
elif isinstance(condition, Branch):
result.append(condition.get_define())
- else:
+ elif num_branch_default >= 1 and isinstance(condition,
Default):
Review Comment:
Yes, it's best to rearrange the order. I've already resubmitted it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
