ruanwenjun commented on code in PR #11614:
URL: https://github.com/apache/dolphinscheduler/pull/11614#discussion_r953247029
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/task/TaskPluginManager.java:
##########
@@ -53,19 +49,19 @@ public void loadPlugin() {
logger.warn("The task plugin has already been loaded");
return;
}
- ServiceLoader.load(TaskChannelFactory.class).forEach(factory -> {
- final String name = factory.getName();
+ PrioritySPIFactory<TaskChannelFactory> prioritySPIFactory = new
PrioritySPIFactory<>(TaskChannelFactory.class);
+ for (Map.Entry<String, TaskChannelFactory> entry :
prioritySPIFactory.getSPIMap().entrySet()) {
+ String factoryName = entry.getKey();
+ TaskChannelFactory factory = entry.getValue();
- logger.info("Registering task plugin: {}", name);
+ logger.info("Registry task plugin: {} - {}", factoryName,
factory.getClass());
Review Comment:
We need to use `Registering` rather than `Registry`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
