jieguangzhou commented on code in PR #11700:
URL: https://github.com/apache/dolphinscheduler/pull/11700#discussion_r958111360
##########
pom.xml:
##########
@@ -684,6 +684,16 @@
</includes>
<flexmark />
</markdown>
+ <formats>
+ <format>
+ <includes>
+ <include>**/*.yaml</include>
+ </includes>
+ <prettier>
+ <prettierVersion>2.0.5</prettierVersion>
Review Comment:
> Can you provide several different types of yaml files to see the effect
after formatting?
>
> As far as I know, we have many different types of yaml files. Such as
`docker-compose yaml` and `spring application yaml`.
I have just tested some of the other YAML files in DS and some of them (may
be not a normal YAML file) are getting errors when formatting.
For example: deploy/kubernetes/dolphinscheduler/templates/configmap.yaml
I think we can't cannot add a formatted operation directly.
WDYT @EricGao888 @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
