DarkAssassinator opened a new issue, #11705:
URL: https://github.com/apache/dolphinscheduler/issues/11705

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What happened
   
   when add some fields in some entity, found that there are many code warninng 
in `org.apache.dolphinscheduler.dao.entity.*`, becauase these long code can 
replaceabled by `Objects.equals()` expression
   
![image](https://user-images.githubusercontent.com/20518339/187466504-1614fdc6-932a-456c-9f22-67da167e7b36.png)
   
   **And i think there are some issue, why it will return false when 
`Objects.equals(environmentCode, command.environmentCode)`**
   
   ### What you expected to happen
   
   clean code 
   
   ### How to reproduce
   
   just review the source code, such as 
`org.apache.dolphinscheduler.dao.entity.Command`
   
   ### Anything else
   
   _No response_
   
   ### Version
   
   dev
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to