[GitHub] [dolphinscheduler] DarkAssassinator commented on a diff in pull request #11762: [Bug] [Common] update IPv4 Pattern

Sun, 04 Sep 2022 08:23:02 -0700 


DarkAssassinator commented on code in PR #11762:
URL: https://github.com/apache/dolphinscheduler/pull/11762#discussion_r962331323


##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java:
##########
@@ -42,7 +42,8 @@
  */
 public class NetUtils {
 
-    private static final Pattern IP_PATTERN = 
Pattern.compile("\\d{1,3}(\\.\\d{1,3}){3,5}$");
+    private static final Pattern IP_PATTERN = Pattern

Review Comment:
   ohh, i agree with u.  I always thought that 
`IPAddressUtil.isIPv4LiteralAddress()` used the same pattern as DS, but just 
checked the source code again and found that the maximum value was also judged. 
i will update it later. thx.
   
![image](https://user-images.githubusercontent.com/20518339/188320928-8fbfd2c0-0455-4be9-971e-786003faebc7.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to