stalary commented on code in PR #11734:
URL: https://github.com/apache/dolphinscheduler/pull/11734#discussion_r962515086
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DependentProcessDefinition.java:
##########
@@ -60,14 +60,14 @@ public class DependentProcessDefinition {
* get dependent cycle
* @return CycleEnum
*/
- public CycleEnum getDependentCycle() {
+ public CycleEnum getDependentCycle(long processDefinitionCode) {
DependentParameters dependentParameters =
this.getDependentParameters();
List<DependentTaskModel> dependentTaskModelList =
dependentParameters.getDependTaskList();
for (DependentTaskModel dependentTaskModel : dependentTaskModelList) {
List<DependentItem> dependentItemList =
dependentTaskModel.getDependItemList();
for (DependentItem dependentItem : dependentItemList) {
- if (this.getProcessDefinitionCode() ==
dependentItem.getDefinitionCode()) {
+ if (processDefinitionCode ==
dependentItem.getDefinitionCode()) {
Review Comment:
processDefinitionCode should be upstream process code, but current is itself
process code, this due to match error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
