ruanwenjun commented on PR #11810: URL: https://github.com/apache/dolphinscheduler/pull/11810#issuecomment-1238870888
> I've just noticed that the API and E2E tests failed because of replacing `org.testcontainers.shaded.org.apache.commons.lang.StringUtils` with `org.testcontainers.shaded.org.apache.commons.lang3.StringUtils`. testcontainers only provides relocated commons-lang2 but not commons-lang3. > I'll revert this change so that these tests succeed. My main interest is building DolphinScheduler against Hadoop 3, and using commons-lang2 via testcontainers doesn't block it. Given that, we don't have to update LICENSE, NOTICE, and known-dependencies.txt since we still depend on commons-lang2 through testcontainers. Yes, we don't need to change `org.testcontainers.shaded.org.apache.commons.lang.StringUtils`, since it is shaded by test container. It's better to remove `commons-lang2` dependency in pom, but we can do this in another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
