caishunfeng commented on code in PR #11767: URL: https://github.com/apache/dolphinscheduler/pull/11767#discussion_r964731424
########## dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskCallBack.java: ########## @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.plugin.task.api; + +public interface TaskCallBack { + + public void updateRemoteApplicationInfo(int taskInstanceId, String appIds); Review Comment: done ########## dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/AbstractYarnTask.java: ########## @@ -69,17 +81,77 @@ public void handle() throws TaskException { } } + // todo + @Override + public void submitApplication() throws TaskException { + + } + + // todo + @Override + public void trackApplicationStatus() throws TaskException { + + } + /** * cancel application * - * @param status status - * @throws Exception exception + * @throws TaskException exception */ @Override - public void cancelApplication(boolean status) throws Exception { - cancel = true; + public void cancelApplication() throws TaskException { // cancel process - shellCommandExecutor.cancelApplication(); + try { + shellCommandExecutor.cancelApplication(); + } catch (Exception e) { + throw new TaskException("cancel application error", e); + } + } + + /** + * get application ids + * @return + * @throws TaskException + */ + public Set<String> getApplicationIds() throws TaskException { Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
