fengjian1129 commented on code in PR #11598: URL: https://github.com/apache/dolphinscheduler/pull/11598#discussion_r965545185
########## dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/HiveSqlLogThread.java: ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.plugin.task.sql; + +import org.apache.dolphinscheduler.common.utils.LoggerUtils; +import org.apache.dolphinscheduler.plugin.task.api.TaskExecutionContext; +import org.apache.dolphinscheduler.plugin.task.api.utils.LogUtils; + +import org.apache.hive.jdbc.HivePreparedStatement; + +import java.sql.PreparedStatement; +import java.sql.SQLException; +import java.util.List; + +import org.slf4j.Logger; + + +public class HiveSqlLogThread extends Thread { + + private final HivePreparedStatement statement; + + private final Logger hiveMapReduceLogger; + + private final TaskExecutionContext taskExecutionContext; + + public HiveSqlLogThread(PreparedStatement statement, Logger logger, TaskExecutionContext taskExecutionContext) throws SQLException { + this.statement = statement.unwrap(HivePreparedStatement.class); + this.hiveMapReduceLogger = logger; + this.taskExecutionContext = taskExecutionContext; + } + + @Override + public void run() { + String taskLogName = LoggerUtils.buildTaskId(taskExecutionContext.getFirstSubmitTime(), + taskExecutionContext.getProcessDefineCode(), + taskExecutionContext.getProcessDefineVersion(), + taskExecutionContext.getProcessInstanceId(), + taskExecutionContext.getTaskInstanceId()); + taskExecutionContext.setTaskLogName(taskLogName); + + // set the name of the current thread + Thread.currentThread().setName(taskLogName); Review Comment: <img width="782" alt="image" src="https://user-images.githubusercontent.com/35831367/189047832-a7ddbe6b-b667-4328-b35a-c9972983e283.png";> This is printed with the task log,If you do not set a unique taskLogName for this thread, the log content cannot be displayed on the web page -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://user-images.githubusercontent.com/35831367/189047832-a7ddbe6b-b667-4328-b35a-c9972983e283.png"](https://user-images.githubusercontent.com/35831367/189047832-a7ddbe6b-b667-4328-b35a-c9972983e283.png"){kind=link}