EricGao888 commented on code in PR #11588:
URL: https://github.com/apache/dolphinscheduler/pull/11588#discussion_r965645475
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-jupyter/src/main/java/org/apache/dolphinscheduler/plugin/task/jupyter/JupyterTask.java:
##########
@@ -220,7 +200,6 @@ private List<String> populateJupyterOptions() {
@Override
public void cancelApplication(boolean cancelApplication) throws Exception {
- // cancel process
shellCommandExecutor.cancelApplication();
Review Comment:
@caishunfeng BTW, if we could support `Shell on Yarn` task in the future, we
could make jupyter task running in the yarn containers of remote machines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
