rickchengx opened a new pull request, #11878:
URL: https://github.com/apache/dolphinscheduler/pull/11878

   
   
   <!--Thanks very much for contributing to Apache DolphinScheduler. Please 
review 
https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html
 before opening a pull request.-->
   
   
   ## Purpose of the pull request
   
   close: #11877 
   
   ### Environment cannot be removed on the ui of some task plugins
   
   1. Create an environment called `test`.
   2. Create a workflow and create a task (E.g., `PYTHON` task) and remove the 
environment on the ui
   <img width="575" alt="截屏2022-09-09 14 25 18" 
src="https://user-images.githubusercontent.com/38122586/189286038-c641f23e-f0d0-4dfb-895b-484aa27f5cf7.png";>
   
   4. Save the workflow
   5. Reopen the created workflow and find that the environment is still there 
and cannot be removed
   
   <img width="580" alt="截屏2022-09-09 14 26 07" 
src="https://user-images.githubusercontent.com/38122586/189286228-019216c0-317d-48ea-91ff-4f01602dac71.png";>
   
   
   ## Brief change log
   
   change `Fields.useEnvironmentName(model, !model.id)` to 
`Fields.useEnvironmentName(model, !data?.id)`
   
   ## Verify this pull request
   
   manually tested
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to