ruanwenjun commented on code in PR #11329:
URL: https://github.com/apache/dolphinscheduler/pull/11329#discussion_r967746031
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/SqoopParameters.java:
##########
@@ -223,13 +223,13 @@ public ResourceParametersHelper getResources() {
}
SourceMysqlParameter sourceMysqlParameter =
JSONUtils.parseObject(this.getSourceParams(), SourceMysqlParameter.class);
- if (sourceMysqlParameter.getSrcDatasource() != 0) {
- resources.put(ResourceType.DATASOURCE,
sourceMysqlParameter.getSrcDatasource());
+ if (sourceMysqlParameter.getSrcDataSource() != 0) {
+ resources.put(ResourceType.DATASOURCE,
sourceMysqlParameter.getSrcDataSource());
}
TargetMysqlParameter targetMysqlParameter =
JSONUtils.parseObject(this.getTargetParams(), TargetMysqlParameter.class);
- if (targetMysqlParameter.getTargetDatasource() != 0) {
- resources.put(ResourceType.DATASOURCE,
targetMysqlParameter.getTargetDatasource());
+ if (targetMysqlParameter.getTargetDataSource() != 0) {
+ resources.put(ResourceType.DATASOURCE,
targetMysqlParameter.getTargetDataSource());
Review Comment:
You can't do this change directly, this will bring an upgrade issue, the
parameter has been store at database, user need to refresh their database.
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/DataSourceUser.java:
##########
@@ -58,4 +58,64 @@ public class DatasourceUser {
* update time
*/
private Date updateTime;
+
+ public int getId() {
+ return id;
+ }
+
+ public void setId(int id) {
+ this.id = id;
+ }
+
+ public int getUserId() {
+ return userId;
+ }
+
+ public void setUserId(int userId) {
+ this.userId = userId;
+ }
+
+ public int getDataSourceId() {
+ return datasourceId;
+ }
+
+ public void setDataSourceId(int datasourceId) {
+ this.datasourceId = datasourceId;
+ }
+
+ public int getPerm() {
+ return perm;
+ }
+
+ public void setPerm(int perm) {
+ this.perm = perm;
+ }
+
+ public Date getCreateTime() {
+ return createTime;
Review Comment:
You don't need to add `get`, `set` and `toString` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
