caishunfeng commented on code in PR #11260:
URL: https://github.com/apache/dolphinscheduler/pull/11260#discussion_r969212735
##########
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-presto/src/main/java/org/apache/dolphinscheduler/plugin/datasource/presto/param/PrestoDataSourceProcessor.java:
##########
@@ -70,15 +73,16 @@ public BaseDataSourceParamDTO
createDatasourceParamDTO(String connectionJson) {
public BaseConnectionParam createConnectionParams(BaseDataSourceParamDTO
datasourceParam) {
PrestoDataSourceParamDTO prestoParam = (PrestoDataSourceParamDTO)
datasourceParam;
String address = String.format("%s%s:%s", Constants.JDBC_PRESTO,
prestoParam.getHost(), prestoParam.getPort());
- String jdbcUrl = address + "/" + prestoParam.getDatabase();
+ String jdbcUrl = address + Constants.SLASH + prestoParam.getDatabase();
PrestoConnectionParam prestoConnectionParam = new
PrestoConnectionParam();
prestoConnectionParam.setUser(prestoParam.getUserName());
prestoConnectionParam.setPassword(PasswordUtils.encodePassword(prestoParam.getPassword()));
prestoConnectionParam.setOther(transformOther(prestoParam.getOther()));
prestoConnectionParam.setAddress(address);
prestoConnectionParam.setJdbcUrl(jdbcUrl);
- prestoConnectionParam.setDatabase(prestoParam.getDatabase());
+
prestoConnectionParam.setDatabase(prestoParam.getDatabase().split(Constants.SLASH)[0]);
+
prestoConnectionParam.setSchema(prestoParam.getDatabase().split(Constants.SLASH)[1]);
Review Comment:
If user set the database not in `database/schema` format, it will error.
Why not add the schema input in the UI for presto datasource?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
