fuchanghai commented on code in PR #11774:
URL: https://github.com/apache/dolphinscheduler/pull/11774#discussion_r971937865


##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/ProcessAlertManager.java:
##########
@@ -217,13 +216,7 @@ public void sendAlertWorkerToleranceFault(ProcessInstance 
processInstance, List<
     public void sendAlertProcessInstance(ProcessInstance processInstance,
                                          List<TaskInstance> taskInstances,
                                          ProjectUser projectUser) {
-
-        if (!isNeedToSendWarning(processInstance)) {

Review Comment:
   Because it has been judged before calling the method sendAlertProcessInstance



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to