zhongjiajie commented on code in PR #11944: URL: https://github.com/apache/dolphinscheduler/pull/11944#discussion_r972550899
########## dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/tasks/openmldb.py: ########## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Task OpenMLDB.""" + +from pydolphinscheduler.constants import TaskType +from pydolphinscheduler.core.task import Task + + +class OpenMLDB(Task): + """Task OpenMLDB object, declare behavior for OpenMLDB task to dolphinscheduler. + + :param name: task name + :param zk: OpenMLDB cluster zookeeper address, e.g. 127.0.0.1:2181. + :param zk_path: OpenMLDB cluster zookeeper path, e.g. /openmldb. Review Comment: How about using the whole word `zookeeper` instead of short cut `zk` ```suggestion :param zookeeper: OpenMLDB cluster zookeeper address, e.g. 127.0.0.1:2181. :param zookeeper_path: OpenMLDB cluster zookeeper path, e.g. /openmldb. ``` and we can using the different name of input parameter and attribute name, means ```py def __init__(self, name, zk, zk_path, execute_mode, sql, *args, **kwargs): super().__init__(name, TaskType.OPENMLDB, *args, **kwargs) self.zk = zookeeper self.zk_path = zookeeper_path ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
