reele commented on code in PR #11677:
URL: https://github.com/apache/dolphinscheduler/pull/11677#discussion_r973815827
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TaskInstanceMapper.java:
##########
@@ -81,7 +81,7 @@ IPage<TaskInstance>
queryTaskInstanceListPaging(IPage<TaskInstance> page,
* @param endTime endTime
* @return task instance
*/
- TaskInstance queryLastTaskInstance(@Param("taskCode") long taskCode,
@Param("startTime") Date startTime, @Param("endTime") Date endTime);
+ TaskInstance queryLastTaskInstance(@Param("taskCode") long taskCode,
@Param("processInstanceId") long processInstanceId);
Review Comment:
> A task should be finished yesterday
This is just one of the cases, what if the task is allowed to finish in the
next days?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
