rickchengx commented on PR #11589:
URL: 
https://github.com/apache/dolphinscheduler/pull/11589#issuecomment-1250820539

   Hi, @ruanwenjun , @EricGao888 , I've made changes to my PR as below:
   
   1. Use `SensitiveDataConverter` to uniformly mask sensitive information in 
task logs.
   2. Each task plugin can add its own regular match expressions to 
`SensitiveDataConverter` through `addMaskPattern()`. E.g., `Sqoop` task adds 
its own regular expression in `init()`:
   
   ```
   SensitiveDataConverter.addMaskPattern(SqoopConstants.SQOOP_PASSWORD_REGEX);
   ```
   
   This PR solves the problem of the mysql password in the sqoop task log. If 
others find that other task types will output sensitive information in the log, 
they only need to add their own regular expression through `addMaskPattern()` 
in the `init()` of the task plugin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to