[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #12059: [Bug-#12057][task-plugin] fix when the sql query result is empty, the email fails to send the attachment, and an exception will be reported

Tue, 20 Sep 2022 04:37:34 -0700 


caishunfeng commented on code in PR #12059:
URL: https://github.com/apache/dolphinscheduler/pull/12059#discussion_r975246713


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java:
##########
@@ -255,6 +255,15 @@ private String resultProcess(ResultSet resultSet) throws 
Exception {
                 resultJSONArray.add(mapOfColValues);
                 rowCount++;
             }
+            // result is null,output table metadata
+            if (resultJSONArray.isEmpty()) {

Review Comment:
   > 1. int num = md.getColumnCount(); 如果num为零，怎么办？
   > 2. 如果resultJSONArray的数据里全是填充的， 267行的代码就没有意义了
   
   Hi @githublaohu please use the English comments, which can make more 
developers understand, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to