DarkAssassinator commented on code in PR #12050:
URL: https://github.com/apache/dolphinscheduler/pull/12050#discussion_r978602838
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/registry/ServerNodeManager.java:
##########
@@ -81,11 +82,29 @@ public class ServerNodeManager implements InitializingBean {
private final ReentrantReadWriteLock.ReadLock workerNodeInfoReadLock =
workerNodeInfoLock.readLock();
private final ReentrantReadWriteLock.WriteLock workerNodeInfoWriteLock =
workerNodeInfoLock.writeLock();
+ private final ReentrantReadWriteLock registryWorkerGroupLock = new
ReentrantReadWriteLock();
+ private final ReentrantReadWriteLock.ReadLock registryWorkerGroupReadLock
= registryWorkerGroupLock.readLock();
+ private final ReentrantReadWriteLock.WriteLock
registryWorkerGroupWriteLock = registryWorkerGroupLock.writeLock();
+
+ private final ReentrantReadWriteLock dbWorkerGroupLock = new
ReentrantReadWriteLock();
+ private final ReentrantReadWriteLock.ReadLock dbWorkerGroupReadLock =
dbWorkerGroupLock.readLock();
+ private final ReentrantReadWriteLock.WriteLock dbWorkerGroupWriteLock =
dbWorkerGroupLock.writeLock();
Review Comment:
> I don' t think we need to add these locks and the
`registryWorkerGroupNodes`, `dbWorkerGroupNodes` these two map.
yes, u are right, these locks are really unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
