EricGao888 commented on code in PR #12106:
URL: https://github.com/apache/dolphinscheduler/pull/12106#discussion_r979267425
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxTask.java:
##########
@@ -419,6 +438,58 @@ private String buildShellCommandFile(String
jobConfigFilePath, Map<String, Prope
return fileName;
}
+ private String buildYarnShellCommandFile(String jobConfigFilePath,
Map<String, Property> paramsMap, String dataxHdfsPath, String
dataxOnYarnDependJar)
Review Comment:
The improvement of `ShellCommandExecutor` I mentioned above is just a
suggestion not a requirement here. You don't need to do it in this PR : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
