kezhenxu94 commented on code in PR #12126:
URL: https://github.com/apache/dolphinscheduler/pull/12126#discussion_r979434190
##########
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/pom.xml:
##########
@@ -127,6 +133,10 @@
<artifactId>log4j</artifactId>
<groupId>log4j</groupId>
</exclusion>
+ <exclusion>
+ <groupId>org.apache.htrace</groupId>
+ <artifactId>htrace-core4</artifactId>
+ </exclusion>
Review Comment:
These are unnecessary
##########
dolphinscheduler-master/pom.xml:
##########
@@ -148,6 +154,10 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-reload4j</artifactId>
</exclusion>
+ <exclusion>
Review Comment:
Remove
##########
pom.xml:
##########
@@ -92,6 +92,7 @@
<docker.tag>${project.version}</docker.tag>
<docker.build.skip>true</docker.build.skip>
<docker.push.skip>true</docker.push.skip>
+ <htrace.version>4.1.1</htrace.version>
Review Comment:
Remove this
##########
dolphinscheduler-api/pom.xml:
##########
@@ -190,6 +190,13 @@
<artifactId>spring-cloud-starter-kubernetes-fabric8-config</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-noop-htrace</artifactId>
+ <version>${htrace.version}</version>
+ <scope>runtime</scope>
Review Comment:
These are unnecessary. Please remove
```suggestion
```
##########
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-hive/pom.xml:
##########
@@ -91,6 +97,10 @@
<artifactId>log4j</artifactId>
<groupId>log4j</groupId>
</exclusion>
+ <exclusion>
Review Comment:
Remove
##########
dolphinscheduler-common/pom.xml:
##########
@@ -188,6 +188,11 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-noop-htrace</artifactId>
+ <version>${htrace.version}</version>
Review Comment:
Same here
##########
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/pom.xml:
##########
@@ -78,6 +78,12 @@
<artifactId>spring-jdbc</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-noop-htrace</artifactId>
+ <version>${htrace.version}</version>
Review Comment:
Here
##########
dolphinscheduler-server/pom.xml:
##########
@@ -140,6 +140,11 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-noop-htrace</artifactId>
+ <version>${htrace.version}</version>
Review Comment:
Remove
##########
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-hive/pom.xml:
##########
@@ -42,6 +42,12 @@
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-noop-htrace</artifactId>
+ <version>${htrace.version}</version>
Review Comment:
Remove
##########
dolphinscheduler-master/pom.xml:
##########
@@ -95,6 +95,12 @@
<artifactId>caffeine</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.hbase.thirdparty</groupId>
+ <artifactId>hbase-noop-htrace</artifactId>
+ <version>${htrace.version}</version>
Review Comment:
Remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
