zhongjiajie commented on code in PR #12146:
URL: https://github.com/apache/dolphinscheduler/pull/12146#discussion_r979708629
##########
docs/configs/docs3-1-0.js:
##########
@@ -25,19 +25,19 @@ export default {
children: [
{
title: 'Introduction',
- link:
'/en-us/docs/dev/user_doc/about/introduction.html',
+ link:
'/en-us/docs/3.1.0/user_doc/about/introduction.html',
Review Comment:
you should keep the document in the old name, `docsdev.js`, it will auto
change the file name during the sync process in `dolphinscheudler-website`
repo, see more detail in
https://github.com/apache/dolphinscheduler-website/blob/master/scripts/rsync_content.sh#L109
##########
docs/docs/en/history-versions.md:
##########
@@ -4,6 +4,10 @@
#### Setup instructions, are available for each stable version of Apache
DolphinScheduler below:
+### Versions: 3.1.0
+
+#### Links： [3.1.0 文档](../3.1.0/user_doc/about/introduction.md)
Review Comment:
```suggestion
#### Links： [3.1.0 Document](../3.1.0/user_doc/about/introduction.md)
```
##########
docs/configs/site.js:
##########
@@ -45,7 +45,7 @@ export default {
children: [
{
key: 'docs0',
- text: 'latest(3.0.0)',
+ text: 'latest(3.1.0)',
Review Comment:
we should merge #12139 and show version 3.0.1 and 3.1.0 both in our website
##########
docs/configs/site.js:
##########
@@ -45,7 +45,7 @@ export default {
children: [
{
key: 'docs0',
- text: 'latest(3.0.0)',
+ text: 'latest(3.1.0)',
Review Comment:
And there is one more thing here, if we merge this patch, the website will
show the version 3.1.0 document, but we have three days for the ASF vote
process.
But other change should be before the voting process, so our doc show we
should separate into two PR instead of a single one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
