EricGao888 commented on PR #12311: URL: https://github.com/apache/dolphinscheduler/pull/12311#issuecomment-1274524164
Currently we use `check` in CI but `apply` in pre-commit hook as execution goal of `Spotless`, see: https://github.com/apache/dolphinscheduler/blob/04e1b88c1c423ca9216af34539cdedf1ac405e82/pom.xml#L679-L686 https://github.com/apache/dolphinscheduler/blob/04e1b88c1c423ca9216af34539cdedf1ac405e82/.pre-commit-config.yaml#L58-L65 I'm thinking about changing the `apply` in pre-commit hook to `check`. The reason is if I add a `regex step` to block `import org.powermock.*`, contributors may get quite confused when pre-commit hook automatically deletes the import, just the same as the `wildcard imports` we discussed before: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r945087368 WDYT @kezhenxu94 @zhongjiajie -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
