[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #12328: [improvement] Migrate all UT cases from jUnit4 to jUnit5 in dao module

Tue, 11 Oct 2022 19:59:52 -0700 


EricGao888 commented on code in PR #12328:
URL: https://github.com/apache/dolphinscheduler/pull/12328#discussion_r992941692


##########
dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/upgrade/WorkerGroupDaoTest.java:
##########
@@ -25,7 +25,8 @@
 
 import javax.sql.DataSource;
 
-import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
 import org.junit.runner.RunWith;

Review Comment:
   Same as above



##########
dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/AlertDaoTest.java:
##########
@@ -23,8 +23,8 @@
 
 import java.util.List;
 
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
 import org.junit.runner.RunWith;

Review Comment:
   We need to remove this, use `ExtendWith` instead as stated in #12301 SOP.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to