fuchanghai commented on code in PR #12340:
URL: https://github.com/apache/dolphinscheduler/pull/12340#discussion_r994132300
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/SchedulerController.java:
##########
@@ -158,7 +158,7 @@ public Result updateSchedule(@ApiIgnore
@RequestAttribute(value = SESSION_USER)
@PathVariable(value = "id") Integer id,
@RequestParam(value = "schedule") String
schedule,
@RequestParam(value = "warningType", required
= false, defaultValue = DEFAULT_WARNING_TYPE) WarningType warningType,
- @RequestParam(value = "warningGroupId",
required = false) int warningGroupId,
+ @RequestParam(value = "warningGroupId",
required = false, defaultValue = DEFAULT_NOTIFY_GROUP_ID) int warningGroupId,
Review Comment:
> Please note different file name, this is 'SchedulerController.java", that
is 'ExecutorController.java'
sorry ,but i don't think ```warningGroupId``` should be pointed default
value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
