EricPyZhou commented on code in PR #12076:
URL: https://github.com/apache/dolphinscheduler/pull/12076#discussion_r996369354


##########
dolphinscheduler-ui/src/views/projects/task/components/node/types.ts:
##########
@@ -91,7 +91,9 @@ interface ISwitchResult {
 }
 
 interface ISourceItem {
-  id: number
+  id?: number,
+  resourceName: string,
+  res?: string

Review Comment:
   > what's the meaning of `res`? Would it be better to use a full word?
   
   ya I agree that 'res' is not clear. It is kinda hard to change it because 
'res' corresponds to 'res' field in the backend. For a temporal fix, I put a 
comment box there to illustrate what 'resourceName' and 'res' are.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to