DarkAssassinator opened a new pull request, #12445:
URL: https://github.com/apache/dolphinscheduler/pull/12445

   <!--Thanks very much for contributing to Apache DolphinScheduler. Please 
review 
https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html
 before opening a pull request.-->
   
   ## Purpose of the pull request
   
   + This PR will close: #12425 
   Please check the `@Transactional` comment. Becuase `@Transactional` just 
will rollback on `RuntimeException` and `Error` but not on `checked 
exceptions`. To roll back checked exception, we need to specify the 
`rollbackFor`
   
![image](https://user-images.githubusercontent.com/20518339/196686769-053fc432-6660-4b5b-af2a-33372469aa68.png)
   
   🙋 Next i will double check all the `@Transactional`
   
   ## Brief change log
   
   + Specify the `rollbackFor`
   + Clear some comments.
   
   ## Verify this pull request
   
   This pull request is already covered by existing tests
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to