rickchengx opened a new pull request, #12452:
URL: https://github.com/apache/dolphinscheduler/pull/12452

   <!--Thanks very much for contributing to Apache DolphinScheduler. Please 
review 
https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html
 before opening a pull request.-->
   
   ## Purpose of the pull request
   
   * close: #12451 
   * related: #12358 
   
   
   Since `cluster.getConfig()` will return `{"k8s": "<kubeconfig>"}` rather 
than return the `<kubeconfig>` directly.
   We need to use `ClusterConfUtils.getK8sConfig(cluster.getConfig())` to 
extract the `<kubeconfig>` from the json string.
   
   Note that although `cluster.getConfig()` cannot return the correct 
kubeconfig now, `DefaultKubernetesClient(config)` will automatically read the 
kubeconfig from `~/.kube/config` instead. So the bug that existed in #12358 may 
not be seen by user.
   
   
   <!--(For example: This pull request adds checkstyle plugin).-->
   
   ## Brief change log
   
   
   
   
   <!--*(for example:)*
   - *Add maven-checkstyle-plugin to root pom.xml*
   -->
   
   ## Verify this pull request
   
   manually tested
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to