DarkAssassinator commented on issue #12403: URL: https://github.com/apache/dolphinscheduler/issues/12403#issuecomment-1285627292
> > because the scope of this part of the refactoring is relatively large, so I split it into multiple sub-tasks, in order to control the scope of influence and facilitate review and merge. cc @EricGao888 @songjianet > > @DarkAssassinator I'm +1 to the refactoring of `ProcessServiceImpl `. But `ProcessServiceImpl` is in one of the core modules, I think we should add related unit tests during the refactoring instead of after the refactoring. > > BTW, may I ask whether you want to do all of these by yourself or need some more hands? Sure, one of the purposes of refactoring it is that the current test rate coverage is not enough. need some more hands? -> Sure, @fuchanghai will help me to refactor it, and welcome more hands to join in. And I plan to focus on refactoring this part for a while. If it is delayed for too long, it may cost more work later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
