Radeity commented on code in PR #12197:
URL:
https://github.com/apache/dolphinscheduler/pull/12197#discussion_r1006532774
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/builder/TaskExecutionContextBuilder.java:
##########
@@ -126,6 +127,24 @@ public TaskExecutionContextBuilder
buildProcessDefinitionRelatedInfo(ProcessDefi
return this;
}
+ /**
+ * build execPath related info
+ *
+ * @return TaskExecutionContextBuilder
+ */
+ public TaskExecutionContextBuilder buildExecPathRelatedInfo() {
Review Comment:
> > I think it should setExecutePath and appInfoPath in worker before task
running. cc @ruanwenjun
>
> Yes, it should be moved to worker and should be set before yarn task
running, I am not sure if other task will need this, you can simply put this
before all task running.
>
> @Radeity In fact, the master doesn't know execPath, it is defined in
worker, different worker may have different path, master doesn't know the
execpath
Oops, Thanks for reminding! I have ignored that different workers may have
different `DATA_BASEDIR`. I'll change this part of code, but, i'll still keep
`appInfoPath`, is that okay?
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/builder/TaskExecutionContextBuilder.java:
##########
@@ -126,6 +127,24 @@ public TaskExecutionContextBuilder
buildProcessDefinitionRelatedInfo(ProcessDefi
return this;
}
+ /**
+ * build execPath related info
+ *
+ * @return TaskExecutionContextBuilder
+ */
+ public TaskExecutionContextBuilder buildExecPathRelatedInfo() {
Review Comment:
> > I think it should setExecutePath and appInfoPath in worker before task
running. cc @ruanwenjun
>
> Yes, it should be moved to worker and should be set before yarn task
running, I am not sure if other task will need this, you can simply put this
before all task running.
>
> @Radeity In fact, the master doesn't know execPath, it is defined in
worker, different worker may have different path, master doesn't know the
execpath
Oops, thanks for reminding! I have ignored that different workers may have
different `DATA_BASEDIR`. I'll change this part of code, but, i'll still keep
`appInfoPath`, is that okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
