caishunfeng commented on code in PR #12538:
URL:
https://github.com/apache/dolphinscheduler/pull/12538#discussion_r1006686975
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/k8s/K8sTaskMainParameters.java:
##########
@@ -19,70 +19,27 @@
import java.util.Map;
+import lombok.Data;
+
/**
* k8s task parameters
*/
+@Data
public class K8sTaskMainParameters {
private String image;
+ private String command;
private String namespaceName;
private String clusterName;
private double minCpuCores;
private double minMemorySpace;
private Map<String, String> paramsMap;
- public String getImage() {
- return image;
- }
-
- public void setImage(String image) {
- this.image = image;
- }
-
- public double getMinCpuCores() {
- return minCpuCores;
- }
-
- public void setMinCpuCores(double minCpuCores) {
- this.minCpuCores = minCpuCores;
- }
-
- public double getMinMemorySpace() {
- return minMemorySpace;
- }
-
- public void setMinMemorySpace(double minMemorySpace) {
- this.minMemorySpace = minMemorySpace;
- }
-
- public String getNamespaceName() {
- return namespaceName;
- }
-
- public void setNamespaceName(String namespaceName) {
- this.namespaceName = namespaceName;
- }
-
- public String getClusterName() {
- return clusterName;
- }
-
- public void setClusterName(String clusterName) {
- this.clusterName = clusterName;
- }
-
- public Map<String, String> getParamsMap() {
- return paramsMap;
- }
-
- public void setParamsMap(Map<String, String> paramsMap) {
- this.paramsMap = paramsMap;
- }
-
@Override
public String toString() {
return "K8sTaskMainParameters{"
+ "image='" + image + '\''
+ + ", command='" + command + '\''
Review Comment:
Remove the `toString` method due to `@Data` contains `@ToString`.
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/K8sTaskParameters.java:
##########
@@ -81,6 +53,7 @@ public String toString() {
return "K8sTaskParameters{"
+ "image='" + image + '\''
+ ", namespace='" + namespace + '\''
+ + ", command='" + command + '\''
Review Comment:
Remove the `toString` method due to `@Data` contains `@ToString`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
