DarkAssassinator commented on code in PR #12523:
URL:
https://github.com/apache/dolphinscheduler/pull/12523#discussion_r1008693237
##########
script/install.sh:
##########
@@ -27,7 +28,10 @@ echo "1.create directory"
# If install Path equal to "/" or related path is "/" or is empty, will cause
directory "/bin" be overwrite or file adding,
# so we should check its value. Here use command `realpath` to get the related
path, and it will skip if your shell env
# without command `realpath`.
-if [ ! -d $installPath ];then
+if [ ${baseDir} = $installPath ]; then
+ echo "Parameter installPath can not be same as the current path (pwd)."
Review Comment:
echo "Fatal: The installPath can not be same as the current path:
${installPath}" may be better, WDYT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
