caishunfeng commented on code in PR #12552:
URL:
https://github.com/apache/dolphinscheduler/pull/12552#discussion_r1011243391
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ResourcesServiceImpl.java:
##########
@@ -1871,6 +1874,61 @@ public Resource queryResourcesFileInfo(String userName,
String fileName) {
return (Resource) resourceResponse.getData();
}
+ @Override
+ public Map<String, Object> deleteDataTransferData(User loginUser, Integer
days) {
Review Comment:
> I have changed it to `Result<Object>`, the same as other methods.
The `Result<Object>` is also not clearly too, because it still do like
```
Map<String, Object> data = new HashMap<>();
data.put("successList", successList);
data.put("failList", failList);
putMsg(result, Status.SUCCESS);
result.setData(data);
```
please see
https://github.com/apache/dolphinscheduler/blob/9e0c9af1a5070b6a55750737aff2026233b26952/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessTaskRelationServiceImpl.java#L229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
