jackfanwan commented on code in PR #12722:
URL:
https://github.com/apache/dolphinscheduler/pull/12722#discussion_r1014637638
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java:
##########
@@ -821,7 +821,7 @@ public Map<String, Object> updateTaskWithUpstream(User
loginUser, long projectCo
} else {
queryUpStreamTaskCodeMap = new HashMap<>();
Review Comment:
> I think it's not a bug, because this else branch will create a empty
`queryUpStreamTaskCodeMap`.
>
> BTW, this method is difficult to understand and missing comments, 😢
because upstreamTaskCodes always empty, so the if branch will not execute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
