rickchengx opened a new pull request, #12854:
URL: https://github.com/apache/dolphinscheduler/pull/12854

   
   
   <!--Thanks very much for contributing to Apache DolphinScheduler. Please 
review 
https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html
 before opening a pull request.-->
   
   ## Purpose of the pull request
   
   * close: #12853 
   
   Currently, the `ResourcePermissionCheckService` is not well tested by the UT 
of `ResourcePermissionCheckServiceTest` because the object under test (i.e., 
`resourcePermissionCheckService`) is mocked by `Mockito`. The code logic of 
`resourcePermissionCheckService` is not covered by UT.
   
   
https://github.com/apache/dolphinscheduler/blob/775b3f87b407a738f4ac8938ef6bce59b7f7b59a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckServiceTest.java#L58-L59
   
   
https://github.com/apache/dolphinscheduler/blob/775b3f87b407a738f4ac8938ef6bce59b7f7b59a/dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckServiceTest.java#L68-L75
   
   ## Brief change log
   
   * Improve the ut of `ResourcePermissionCheckServiceTest`
   
   ## Verify this pull request
   
   covered by UT
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to