rickchengx commented on code in PR #12851:
URL:
https://github.com/apache/dolphinscheduler/pull/12851#discussion_r1018792502
##########
dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/DataSourceMapperTest.java:
##########
@@ -272,6 +272,32 @@ public void testListAuthorizedDataSource() {
.containsAll(Arrays.asList(dataSourceIds)));
}
+ @Test
+ public void testSelectPagingByIds() {
+ User user1 = createGeneralUser("user1");
+ User user2 = createGeneralUser("user2");
+ DataSource dataSource1 = createDataSource(user1.getId(), "name1");
Review Comment:
> We could improve the readability of UT cases with better naming to see the
relationship between datasource and its owner.
Hi @EricGao888 , thanks for your suggestion. I've made this PR more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
