[dolphinscheduler] branch dev updated: [Improvement-12856][UT] Refactor duplicated code fragment in UdfFuncMapperTest (#12857)

[chufenggao]

This is an automated email from the ASF dual-hosted git repository.

chufenggao pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new 83f9588eb0 [Improvement-12856][UT] Refactor duplicated code fragment 
in UdfFuncMapperTest (#12857)
83f9588eb0 is described below

commit 83f9588eb07832f058c3fafe990a997069baf68f
Author: Guanhua Li <guanhua....@alibaba-inc.com>
AuthorDate: Tue Nov 15 22:59:11 2022 +0800

    [Improvement-12856][UT] Refactor duplicated code fragment in 
UdfFuncMapperTest (#12857)
---
 .../dao/mapper/UdfFuncMapperTest.java              | 38 ++++++----------------
 1 file changed, 10 insertions(+), 28 deletions(-)

diff --git 
a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapperTest.java
 
b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapperTest.java
index a5a94043fc..db514fce72 100644
--- 
a/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapperTest.java
+++ 
b/dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapperTest.java
@@ -93,16 +93,7 @@ public class UdfFuncMapperTest extends BaseDaoTest {
      * @return User
      */
     private User insertOneUser() {
-        User user = new User();
-        user.setUserName("user1");
-        user.setUserPassword("1");
-        user.setEmail("x...@123.com");
-        user.setUserType(UserType.GENERAL_USER);
-        user.setCreateTime(new Date());
-        user.setTenantId(1);
-        user.setUpdateTime(new Date());
-        userMapper.insert(user);
-        return user;
+        return insertOneUser("user1");
     }
 
     /**
@@ -111,6 +102,15 @@ public class UdfFuncMapperTest extends BaseDaoTest {
      * @return User
      */
     private User insertOneUser(String userName) {
+        return createGeneralUser(userName);
+    }
+
+    /**
+     * create general user
+     *
+     * @return User
+     */
+    private User createGeneralUser(String userName) {
         User user = new User();
         user.setUserName(userName);
         user.setUserPassword("1");
@@ -140,24 +140,6 @@ public class UdfFuncMapperTest extends BaseDaoTest {
         return udfUser;
     }
 
-    /**
-     * create general user
-     *
-     * @return User
-     */
-    private User createGeneralUser(String userName) {
-        User user = new User();
-        user.setUserName(userName);
-        user.setUserPassword("1");
-        user.setEmail("x...@123.com");
-        user.setUserType(UserType.GENERAL_USER);
-        user.setCreateTime(new Date());
-        user.setTenantId(1);
-        user.setUpdateTime(new Date());
-        userMapper.insert(user);
-        return user;
-    }
-
     /**
      * test update
      */