rickchengx opened a new pull request, #12917:
URL: https://github.com/apache/dolphinscheduler/pull/12917

   <!--Thanks very much for contributing to Apache DolphinScheduler. Please 
review 
https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html
 before opening a pull request.-->
   
   ## Purpose of the pull request
   
   * close: #12916 
   
   Currently, there is no permission check when user query or download log by 
task instance id.
   
   
   <img width="1386" alt="截屏2022-11-16 09 55 30" 
src="https://user-images.githubusercontent.com/38122586/202098814-7afaea49-0a57-43be-8476-ea56da0a28d2.png";>
   
   ## Brief change log
   
   Add permission check when query or download log
   
   
   ## Verify this pull request
   
   covered by UT and manually tested as below
   
   Note that the task instance id 1 is not created by current login user.
   
   <img width="1062" alt="截屏2022-11-16 14 11 12" 
src="https://user-images.githubusercontent.com/38122586/202099690-aa1e9955-4928-4bb1-809f-8486eb5b5359.png";>
   
   <img width="847" alt="截屏2022-11-16 14 10 21" 
src="https://user-images.githubusercontent.com/38122586/202099715-a44b7c06-8caf-4c73-b1bf-b5893188d750.png";>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to