Radeity commented on issue #12713:
URL:
https://github.com/apache/dolphinscheduler/issues/12713#issuecomment-1317967932
Hi, @SbloodyS
In shell task, DS supports to use parameters like `echo ${val}`. However, we
can't find out whether variable `val` is defined in upstream tasks or in
worker's env variables, which means, use `DFS` or `TopSort` to find whether
current parameters appear before may causes error because we don't know what
env variables user defines.
I suggest to add explicit statement when using upstream task parameter like
FILE type parameter(https://github.com/apache/dolphinscheduler/pull/12552), use
`${taskName.Key}` and set directory `IN` to define a parameter input from
upstream task. It's more clear and can be used to parameter check. WDYT? If you
think it's reasonable, i'll create new issue and change definition of file type
input parameter from `taskName.Key` to `${taskName.Key}`, either.
<img width="1183" alt="image"
src="https://user-images.githubusercontent.com/45198818/202337422-1bc55bea-ca98-4cce-8cb3-dbfa6382bec4.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/45198818/202337422-1bc55bea-ca98-4cce-8cb3-dbfa6382bec4.png"](https://user-images.githubusercontent.com/45198818/202337422-1bc55bea-ca98-4cce-8cb3-dbfa6382bec4.png"){kind=link}