DarkAssassinator commented on PR #12969: URL: https://github.com/apache/dolphinscheduler/pull/12969#issuecomment-1323691986
parameters -> DTO is a good refactor, but why all service return still keep `Result`? I think that `Result` is a bad partice for service impl. If failed, service just need throw `ServiceException`, no need update the `Result`, such as https://github.com/apache/dolphinscheduler/pull/12736/commits/f7caa6a92ea3e784db4ab0cbf96a00811a985c50. WDYT. cc @SbloodyS @caishunfeng -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
