Radeity commented on issue #12873: URL: https://github.com/apache/dolphinscheduler/issues/12873#issuecomment-1325282473
> hi @Radeity because many task may use the same environment, so DS add `t_ds_environment` to manage. So u mean that we should add a environment string column in task_instance? But I think the environemt field is only useful for some tasks that use bash, not all task types, so I think the environemt field does not belong to the taskInstance, but should be a custom parameter of the task plugins. So we should abstract task custom parameter to a other db table to inrease query performance. WDYT. Hi, @DarkAssassinator. I just find out i misunderstand in the first comment, so correct myself in the second comment, which i mean is saving field `config` as String is reasonable in DS. Actually i have no doubts about the current implementation and agree with your idea, thanks for your reply! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
