fuchanghai commented on PR #12610:
URL:
https://github.com/apache/dolphinscheduler/pull/12610#issuecomment-1325803744
done
---Original---
From: "Yann ***@***.***>
Date: Mon, Nov 21, 2022 19:19 PM
To: ***@***.***>;
Cc: ***@***.***>;"State ***@***.***>;
Subject: Re: [apache/dolphinscheduler] [Improvement #12471] Migrate
alldqrule-related interface functions from ProcessServiceImpl (PR #12610)
@DarkAssassinator commented on this pull request.
LGTM, just need change @component to @repository
In
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/repository/impl/DqComparisonTypeDaoImpl.java:
> + * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +
* See the License for the specific language governing permissions and + *
limitations under the License. + */ + +package
org.apache.dolphinscheduler.dao.repository.impl; + +import
org.apache.dolphinscheduler.dao.entity.DqComparisonType; +import
org.apache.dolphinscheduler.dao.mapper.DqComparisonTypeMapper; +import
org.apache.dolphinscheduler.dao.repository.DqComparisonTypeDao; + +import
org.springframework.beans.factory.annotation.Autowired; +import
org.springframework.stereotype.Component; + ***@***.***
DAO should use @repository
In
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/repository/impl/DqRuleExecuteSqlDaoImpl.java:
> ***@***.*** +public class DqRuleExecuteSqlDaoImpl implements
DqRuleExecuteSqlDao {
same as above
In
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/repository/impl/DqRuleInputEntryDaoImpl.java:
> ***@***.*** +public class DqRuleInputEntryDaoImpl implements
DqRuleInputEntryDao {
same as above
In
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/repository/impl/DqTaskStatisticsValueDaoImpl.java:
> ***@***.*** +public class DqTaskStatisticsValueDaoImpl implements
DqTaskStatisticsValueDao {
same as above
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you modified the open/close state.Message ID:
***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
