zhongjiajie commented on code in PR #12990:
URL:
https://github.com/apache/dolphinscheduler/pull/12990#discussion_r1033074320
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkflowInstanceV2Controller.java:
##########
@@ -0,0 +1,129 @@
+package org.apache.dolphinscheduler.api.controller;
+
+import static org.apache.dolphinscheduler.api.enums.Status.*;
Review Comment:
is this change by you or by spotless itself?
##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml:
##########
@@ -274,6 +278,40 @@
and id <![CDATA[ > ]]> #{id}
order by id asc limit 1
</select>
+ <select id="queryProcessInstanceListV2Paging"
+
resultType="org.apache.dolphinscheduler.dao.entity.ProcessInstance">
+ SELECT
+ instance.id
+ , instance.name, instance.process_definition_version,
instance.process_definition_code, instance.state, instance.recovery,
instance.start_time, instance.end_time, instance.run_times,host,
+ instance.command_type, instance.command_param,
instance.task_depend_type, instance.max_try_times, instance.failure_strategy,
instance.warning_type,
+ instance.warning_group_id, instance.schedule_time,
instance.command_start_time, instance.global_params, instance.flag,
+ instance.update_time, instance.is_sub_process, instance.executor_id,
instance.history_cmd,
+ instance.process_instance_priority,
instance.worker_group,instance.environment_code, instance.timeout,
instance.tenant_id, instance.var_pool,
+ instance.dry_run, instance.test_flag,
instance.next_process_instance_id, instance.restart_time, instance.state_history
Review Comment:
can we directly use
```xml
select
<include refid="baseSql"/>
```
or because we use other col, so we have to use custom col here?
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/WorkflowInstanceV2Controller.java:
##########
@@ -0,0 +1,129 @@
+package org.apache.dolphinscheduler.api.controller;
+
+import static org.apache.dolphinscheduler.api.enums.Status.*;
Review Comment:
we should avoid using `*` in our import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
