[GitHub] [dolphinscheduler] DarkAssassinator commented on a diff in pull request #13013: [Fix-12981]add worker address validator and clear function.

Mon, 28 Nov 2022 05:34:59 -0800 


DarkAssassinator commented on code in PR #13013:
URL: 
https://github.com/apache/dolphinscheduler/pull/13013#discussion_r1033548909


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/registry/ServerNodeManager.java:
##########
@@ -201,13 +203,25 @@ public void notify(Event event) {
         }
 
         private void syncSingleWorkerNodeInfo(String workerAddress, 
WorkerHeartBeat info) {
+            if (!NetUtils.isLegalAddress(workerAddress)) {

Review Comment:
   > I don't think this is needed. You don't need to check all things.
   
   This step is not overly precautionary. Because registry Event will contain 
intermediate nodes, such as `worker`. Please check the following screenshot.
   
![image](https://user-images.githubusercontent.com/20518339/204290503-d29213b5-72b3-4c1d-9cbb-2707a31e8d56.png)
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to