hzyangkai commented on PR #13030:
URL: 
https://github.com/apache/dolphinscheduler/pull/13030#issuecomment-1330074885

   > I think we should keep consistent with these task types to ensure good 
maintainability in the future. So I don't think it's a good idea.
   
   Hi, @SbloodyS , thanks for your review.
   
   I think your advice is good. I will try to  unify the submission behavior of 
all types of tasks and keep consistent with all task types. At the same time, i 
will solve the duplication problem in tasks of type 1, 2 ( perhaps i will use  
"ssh host kill pid" ).
   
   > BTW, You should submit the PR to the dev branch instead of the released 
branch.
   
   thanks. I will submit this pr to the dev branch.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to